Allow including @ and . (dot) characters in keypair name¶
Keypair names currently allow only digits, ascii letters, dashs, underscores and spaces.
When user tries to insert any other character, he gets the error: “Keypair name contains unsafe characters”.
@ (at) and
. (dot) characters in keypair names make it
possible to use the format
It was introduced by https://opendev.org/openstack/nova/commit/c8b0a9a3be7ca276d91d470a629fdd0209812993, to resolve https://bugs.launchpad.net/nova/+bug/937408
Only modified once since to include space in https://opendev.org/openstack/nova/commit/ec0a65d81fd11d26be77b45827a4dd7c77711675
Some end users have the habit of using the format
their keypair name, probably because it is the default comment
generated by ssh-keygen.
Modify the list of safe characters to add the
@ (at) and
Data model impact¶
REST API impact¶
Existing microversion should keep these characters forbidden. A new microversion will allow these characters.
Other end user impact¶
Other deployer impact¶
- Primary assignee:
- Other contributors:
Adding unit tests should be enough to test these special characters.
API reference documentation should explain what characters are allowed for keypair names. See https://docs.openstack.org/api-ref/compute/?expanded=create-or-import-keypair-detail#create-or-import-keypair
Discussion on IRC about the need for a new API microversion: http://eavesdrop.openstack.org/irclogs/%23openstack-nova/%23openstack-nova.2021-03-19.log.html#t2021-03-19T10:02:01