Adds disk latency metrics implementation in the Hyper-V Inspector¶
High latency between I/O requests can be signs of issues. Collecting disk latency metrics can help us detect those issues. Hyper-V Inspector can collect those metrics.
Disk latency metrics are important in telemetry and useful when determining instance’s performance. This spec is about these stats and their implementation in the Hyper-V Inspector.
Add DiskLatencyPollster and PerDeviceDiskLatencyPollster pollsters, which create samples having the properties: * name: ‘disk.latency’ * type: ‘gauge’ * unit: ‘ms’
Add the method ‘inspect_disk_latency’ in Inspector and implementing it in the HyperVInspector, fetching disk latency stats data from Hyper-V VMs, located in the Msvm_AggregationMetricValue objects (further referred to as ‘metrics objects’) associated with the VMs. The metrics objects ‘MetricDefinitionId’ must be the equal to the ‘Id’ of Msvm_AggregationMetricDefinition object having the Caption ‘Average Disk Latency’.
Hyper-V disk metrics were introduced in Windows / Hyper-V Server 2012 R2 (kernel version 6.3). They are not supported in the previous versions.
Data model impact¶
REST API impact¶
Other end user impact¶
Other deployer impact¶
Users will have to add meter ‘disk.latency’ in the disk_source source in pipeline.yaml By default, the disk usage metrics collection is enabled in Nova, we just need to collect the data from the Hyper-V API.
- Primary assignee:
Adds the DiskLatencyPollster and PerDeviceDiskLatencyPollster pollsters
Adds the method ‘inspector_disk_latency’ in Inspector.
Implements the method ‘inspect_disk_latency’ in HyperVInspector.
Adds related unit tests.
Updates ceilometer measurements document.
Once this feature is enabled, it needs tests and bug fixing in the next 2 releases to avoid regression.
Windows / Hyper-V Server 2012 R2 (kernel version 6.3)
Unit tests are needed to test the new pollsters and the implementation on the Hyper-V side.
The added metrics will need to be documented in the measurements section.