In general, TripleO follows the standard “2 +2” review standard, but there are situations where we want to make an exception. This policy is intended to document those exceptions.
Core reviewer time is precious, and there is never enough of it. In some cases, requiring 2 +2’s on a patch is a waste of that core time, so we need to be reasonable about when to make exceptions. While core reviewers are always free to use their judgment about when to merge or not merge a patch, it can be helpful to list some specific situations where it is acceptable and even expected to approve a patch with a single +2.
Part of this information is already in the wiki, but the future of the wiki is in doubt and it’s better to put policies in a place that they can be reviewed anyway.
A core can and should approve patches without a second +2 under the following circumstances:
It is acceptable for a core to self-approve a patch they submitted if it has the requisite 2 +2’s and a CI pass. However, this should not be done if there is any dispute about the patch, such as on a change with 2 +2’s and an unresolved -1.
This policy does not affect CI requirements. Patches must still pass CI before merging.
This policy has been in effect for a while now, but not every TripleO core is aware of it, so it is simply being written down in an official location for reference.
The policy is already in effect.
Ensure all cores are aware of the policy. Once the policy has merged, an email should be sent to openstack-dev referring to it.
Existing wiki on review guidlines: https://wiki.openstack.org/wiki/TripleO/ReviewGuidelines
Previous spec that implemented some of this policy: http://specs.openstack.org/openstack/tripleo-specs/specs/kilo/tripleo-review-standards.html
|Newton||Added co-author +2 policy|
|Ocata||Added note on translation imports|
This work is licensed under a Creative Commons Attribution 3.0 Unported License. http://creativecommons.org/licenses/by/3.0/legalcode