Include the URL of your launchpad blueprint:
As we add more dependencies, we find more cases where we need to customize the logging output for those libraries. Rather than forcing applications to manage their own list of customizations, and rather than having a single large list of customizations in oslo.log, we should change the way we configure the logger tree so that libraries are quiet by default.
We currently attach a logging handler to the root logging node and configure it to emit output to whatever source the user has specified (a file, syslog, etc.) using a default log level. We then use the default_log_levels option to specify different default settings for other libraries, usually to quiet them so that output is only produced at warning or higher levels. This configuration takes advantage of the fact that Python’s logging module configures the loggers in a tree structure, where messages move up the tree until they find a node that handles them.
That gives us a logger structure like:
One drawback to this approach is that new versions of libraries affect the log content and the settings to control them need to be updated fairly frequently. This problem will increase as we start to support more drivers with additional third-party dependencies.
To solve the problem, we configure the loggers so that the root node always only emits data at WARN or higher, and then configure a logger named for the base package of the application to emit messages at the level requested by the logging configuration flags (--debug, --verbose, etc.).
The default_log_levels option will still be supported, but any libraries with custom output levels managed through default_log_levels can be ignored unless their output level is different than WARN. This is a minor optimization in the configuration setup, though, so we don’t need to implement it.
The result would look more like:
The other loggers still exist, but they wouldn’t need custom configuration. They could still be given levels based on the configuration options, in case that turns out to be useful.
Moving all of the Oslo library loggers under the oslo part of the logger tree will require a little custom logic in oslo_log.log.getLogger() to replace "oslo_library" with "oslo.library".
We could keep the Oslo libraries logging under their own library-specific names oslo_config, oslo_concurrency, etc. However, this makes it more difficult to configure them to all log at a consistent level. Because the Oslo library code is a growing part of the overall OpenStack code base, and errors frequently require information about the libraries’ behavior to debug, having them all under a single common node makes it easy to adjust the log output.
We do have default_log_levels and the ability to configure logging through a file instead of just configuration flags, so deployers could set this up themselves. However, the default behavior of oslo.log is supposed to represent a useful configuration for most deployers, so making the change there is better than asking each deployer to figure it out for themselves.
Rather than using WARN as the default level for the root logger, we could use ERROR or even CRITICAL. This would further reduce the extra output, but WARN seems like it should be good enough for most libraries that we are using now. We can evaluate changing the level after the main part of the work is done, since it will be a simple change to experiment with at that point.
Rather than hard-coding the level of the root logger, we could use a configuration option to let the deployer control it. We can evaluate this alternative after the main part of the work is done, since it will be a simple change to experiment with at that point.
No API changes.
We already have the application name as the product_name argument to oslo_log.log.setup(), so we can use it to set up the application’s primary log handler.
All of the existing configuration options will continue to produce the same results.
We can eventually change the default value of default_log_levels, although that’s not necessary at first.
We will want to verify that the log output doesn’t increase significantly when we change the default behavior for the Oslo libraries.
Primary assignee: Doug Hellmann
Other contributors: None
Target Milestone for completion: Liberty-2
The proposed change affects the default log levels, but all of the configuration options will work in the same way so no documentation changes should be needed.
This work is licensed under a Creative Commons Attribution 3.0 Unported License. http://creativecommons.org/licenses/by/3.0/legalcode